Skip to content

Conversation

@mwaskom
Copy link
Member

@mwaskom mwaskom commented Nov 2, 2010

Hey, here are a few Freesurfer utilities. Satra wants to use one of them, but they're not fully tested yet, so I'm not importing them in Freesurfer's init.py and there's a warning about that when you directly import freesurfer.utils.

@chrisgorgo
Copy link
Member

are you sure you want this into master not maint/0.3?

@mwaskom
Copy link
Member Author

mwaskom commented Nov 4, 2010

Nope, I thought I requested a pull into maint/0.3 but apparently that still doesn't work.

@chrisgorgo
Copy link
Member

Looks nice (sorry for the delay). Could you update the CHANGES file to reflect the new functionality and their limitation? Ta.

@mwaskom
Copy link
Member Author

mwaskom commented Dec 3, 2010

Ok, I have now added tests for SampleToSurface and SurfaceScreenshots, and updated the CHANGES file as per Chris's request. This branch is now ready to be pulled. Sorry about the delay.

@chrisgorgo
Copy link
Member

I see you are still working on this branch. When you feel that the changes matured to be pulled again pleas send a request. Thanks - Chris.

@mwaskom
Copy link
Member Author

mwaskom commented Dec 16, 2010

Thanks, once I saw that you had pulled in this branch, I created a new one off master (because was originally branched a looong time ago) and have made all of my updates there. Hopefully will have that ready for a pull at the end of the day.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants