Skip to content

Conversation

mauriliogenovese
Copy link
Contributor

@mauriliogenovese mauriliogenovese commented Mar 21, 2025

I will send some PRs to improve/fix fsl cuda-capable tools with the new gpu support.
This one is about eddy:
eddy_openmp is an old command, new fls uses eddy_cpu
eddy_cuda is missing in some version, in those cases if user requests cuda, just use eddy

eddy_cpu does not enable multithread with OMP_NUM_THREADS variable but with --nthr argument

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.13%. Comparing base (2f85d92) to head (9348f49).

Files with missing lines Patch % Lines
nipype/interfaces/fsl/epi.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #3721 +/- ## =========================================== + Coverage 2.88% 69.13% +66.24%  =========================================== Files 1279 1278 -1 Lines 59413 59271 -142 =========================================== + Hits 1717 40978 +39261  + Misses 57696 18293 -39403 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@mauriliogenovese
Copy link
Contributor Author

the second commit fix this:
EddyInputError: The version compiled for GPU can only use 1 CPU thread (i.e. --nthr=1)

@mauriliogenovese mauriliogenovese force-pushed the fix-eddy-parallel-and-gpu branch from ce24f3e to 9348f49 Compare March 22, 2025 18:03
@mauriliogenovese mauriliogenovese changed the title fix eddy command and multithreading [FIX]eddy command and multithreading Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant