ENH: Remove unused and recently unsupported antsRegistration flag #3695
+33 −34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ANTsX/ANTs@e1e47994b233441726c1440cc2fb077a24287d6bo The flag --use-estimate-learning-rate-once was not used inside of antsRegistration, and was removed on 2022-08-09 in ants commit e1e47994b e1e47994b Examples/antsRegistration.cxx (Nick Tustison 2022-08-09 16:45:01 -0700 453) // option->SetLongName("use-estimate-learning-rate-once");
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #3695 +/- ## ======================================= Coverage 70.81% 70.81% ======================================= Files 1277 1277 Lines 59153 59153 Branches 8590 8590 ======================================= + Hits 41889 41890 +1 Misses 16119 16119 + Partials 1145 1144 -1 ☔ View full report in Codecov by Sentry. |
effigies approved these changes Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/ANTsX/ANTs/commit/e1e47994b233441726c1440cc2fb077a24287d6bo The flag --use-estimate-learning-rate-once was not used inside of antsRegistration, and was removed on 2022-08-09 in ants commit e1e47994b e1e47994b Examples/antsRegistration.cxx (Nick Tustison 2022-08-09 16:45:01 -0700 453) // option->SetLongName("use-estimate-learning-rate-once");List of changes proposed in this PR (pull-request)
Removes unnecessary antsRegistration flag that never had an effect in the code, and has been removed since 2022-08-09.