STY: Apply ruff/Pyflakes rules (F) #3681
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #3681 +/- ## ========================================== - Coverage 70.89% 70.84% -0.06% ========================================== Files 1277 1277 Lines 59212 59116 -96 Branches 9799 9801 +2 ========================================== - Hits 41980 41882 -98 - Misses 16066 16067 +1 - Partials 1166 1167 +1 ☔ View full report in Codecov by Sentry. |
DimitriPapadopoulos force-pushed the F branch 2 times, most recently from 16453da to 70f42d4 Compare DimitriPapadopoulos force-pushed the F branch 3 times, most recently from 98ae899 to f7fef39 Compare 
| | ||
| from nipype.algorithms import misc | ||
| from nipype.utils.filemanip import fname_presuffix | ||
| from nipype.testing.fixtures import create_analyze_pair_file_in_directory |
There was a problem hiding this comment.
You've removed a lot of fixtures from the module namespaces. This could be generally rectified by either moving or importing fixtures from nipype.testing.fixtures into nipype.conftest.
There was a problem hiding this comment.
I've put them back for now.
nipype/utils/filemanip.py Outdated
| else: | ||
| raise |
There was a problem hiding this comment.
This was meant to be a for/else, not a try/except/else. What we need to do is instead:
for ...: try: ... break except FileNotFoundError as e: err = e ... else: raise errThere was a problem hiding this comment.
By the way, sleep(2) should be skipped in the last iteration.
DimitriPapadopoulos force-pushed the F branch 3 times, most recently from a1d311f to dc2b0ed Compare 
F401 imported but unused
F523 `.format` call has unused arguments
F541 f-string without any placeholders
F821 Undefined name I have left some occurrences, to be fixed in a later pull request.
F841 Local variable is assigned to but never used I have left a few occurrences, to be examined later.
F901 `raise NotImplemented` should be `raise NotImplementedError`
2 participants
Summary
Apply Pyflakes (F) rules, except: