STY: Apply ruff/flake8-simplify rules (SIM) #3676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #3676 +/- ## ========================================== + Coverage 70.87% 70.89% +0.02% ========================================== Files 1276 1276 Lines 59238 59209 -29 Branches 9812 9814 +2 ========================================== - Hits 41984 41977 -7 + Misses 16079 16061 -18 + Partials 1175 1171 -4 ☔ View full report in Codecov by Sentry. |
DimitriPapadopoulos force-pushed the SIM branch 3 times, most recently from 3d6d91f to 6542864 Compare DimitriPapadopoulos force-pushed the SIM branch 2 times, most recently from ba2eac6 to a2681fa Compare 
effigies reviewed Oct 6, 2024
DimitriPapadopoulos force-pushed the SIM branch from 30b0b9b to 306689f Compare effigies approved these changes Oct 6, 2024
SIM101 Multiple `isinstance` calls for expression, merge into a single call
SIM103 Return the condition directly
SIM113 Use `enumerate()` for index variable in `for` loop
SIM115 Use a context manager for opening files
SIM118 Use `key in dict` instead of `key in dict.keys()`
SIM201 Use `... != ...` instead of `not ... == ...`
SIM401 Use `.get()` instead of an `if` block
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
DimitriPapadopoulos force-pushed the SIM branch from 306689f to d040d84 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Apply assorted flake8-simplify (SIM) rules.