Skip to content

Conversation

DimitriPapadopoulos
Copy link
Contributor

Summary

Apply Perflint (PERF) rules, except:

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 46.51163% with 23 lines in your changes missing coverage. Please review.

Project coverage is 70.86%. Comparing base (8553b39) to head (60aa048).
Report is 152 commits behind head on master.

Files with missing lines Patch % Lines
nipype/algorithms/misc.py 0.00% 3 Missing ⚠️
nipype/utils/nipype2boutiques.py 25.00% 3 Missing ⚠️
nipype/interfaces/cmtk/cmtk.py 0.00% 2 Missing ⚠️
nipype/interfaces/fsl/fix.py 0.00% 2 Missing ⚠️
nipype/interfaces/io.py 50.00% 1 Missing and 1 partial ⚠️
nipype/pipeline/engine/workflows.py 50.00% 2 Missing ⚠️
nipype/pipeline/plugins/somaflow.py 0.00% 2 Missing ⚠️
nipype/algorithms/confounds.py 0.00% 1 Missing ⚠️
nipype/algorithms/modelgen.py 0.00% 1 Missing ⚠️
nipype/interfaces/ants/segmentation.py 50.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@ Coverage Diff @@ ## master #3674 +/- ## ========================================== + Coverage 70.84% 70.86% +0.02%  ========================================== Files 1276 1276 Lines 59314 59229 -85 Branches 9826 9812 -14 ========================================== - Hits 42019 41975 -44  + Misses 16119 16079 -40  + Partials 1176 1175 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the PERF branch 3 times, most recently from 8b17632 to 0e6a385 Compare October 6, 2024 14:27
PERF401 Use a list comprehension to create a transformed list
PERF403 Use a dictionary comprehension instead of a for-loop
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the PERF branch 2 times, most recently from 63517ff to d5edcc9 Compare October 6, 2024 15:25
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@effigies effigies merged commit c5fa777 into nipy:master Oct 6, 2024
19 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PERF branch October 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants