Skip to content

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 22, 2024

Summary

Apply Ruff-specific rules (RUF), except:

  • RUF002 (seems useless to me)
  • RUF005 (not sure the resulting code is more readable)
  • RUF012 (only useful with MyPy)
  • RUF015 (left for later...)
  • RUF017 (breaks CI, left for later...)
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.

Project coverage is 70.83%. Comparing base (e03ab6f) to head (39e7d3a).
Report is 176 commits behind head on master.

Files with missing lines Patch % Lines
nipype/pipeline/plugins/condor.py 0.00% 2 Missing ⚠️
nipype/pipeline/plugins/lsf.py 0.00% 2 Missing ⚠️
nipype/pipeline/plugins/oar.py 0.00% 2 Missing ⚠️
nipype/pipeline/plugins/pbs.py 0.00% 2 Missing ⚠️
nipype/pipeline/plugins/sge.py 0.00% 2 Missing ⚠️
nipype/pipeline/plugins/slurm.py 0.00% 2 Missing ⚠️
nipype/interfaces/slicer/generate_classes.py 0.00% 1 Missing ⚠️
nipype/pipeline/plugins/base.py 0.00% 1 Missing ⚠️
nipype/pipeline/plugins/sgegraph.py 0.00% 1 Missing ⚠️
nipype/pipeline/plugins/slurmgraph.py 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@ Coverage Diff @@ ## master #3673 +/- ## ======================================= Coverage 70.83% 70.83% ======================================= Files 1276 1276 Lines 59320 59320 Branches 9826 9826 ======================================= Hits 42019 42019 Misses 16125 16125 Partials 1176 1176 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RUF010 Use explicit conversion flag
RUF019 Unnecessary key check before dictionary access
RUF021 Parenthesize `a and b` expressions when chaining `and` and `or` together, to make the precedence clear
RUF022 `__all__` is not sorted
UF023 `__slots__` is not sorted
@effigies effigies merged commit 743b688 into nipy:master Oct 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants