Fix bugs with fsl_out=True and lta_out=True #3583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…rguments with 'fsl_file' and 'lta_file' respectively
effigies reviewed Jun 26, 2023
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@ ## master #3583 +/- ## ========================================== - Coverage 63.19% 63.19% -0.01% ========================================== Files 308 308 Lines 40790 40792 +2 Branches 5487 5489 +2 ========================================== + Hits 25778 25779 +1 + Misses 14009 14000 -9 - Partials 1003 1013 +10
☔ View full report in Codecov by Sentry. |
effigies reviewed Jul 5, 2023
effigies approved these changes Jul 5, 2023
Member
effigies left a comment
effigies left a comment There was a problem hiding this comment.
This looks good, and thanks for your patience. The test failures are unrelated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3582 .
The options 'fsl_out' and 'lta_out'in TKregister2 should check and add arguments with 'fsl_file' and 'lta_file' respectively. Otherwise, a key error would be raised when setting
fsl_out=Trueorlta_out=TrueList of changes proposed in this PR (pull-request)
Tkregister2._format_argso thatfsl_out=Trueandlta_out=Trueoptions use the correct name for the argument and finding the argument value