- Notifications
You must be signed in to change notification settings - Fork 536
[ENH] Issue 3345: Adding FreeSurfer longitudinal interfaces #3529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
18 commits Select commit Hold shift + click to select a range
da35d17 Initial addition of FreeSurfer longitudinal interfaces.
l-espana d6ec3bd Style and testing.
l-espana 0b51c54 Update LongReconAll to separate base template id.
l-espana 6a294be Forgot check-before-commit. Update LongReconAll docstring.
l-espana 6971865 Update longitudinal outputs to match separation of ids.
l-espana 2d2072f Update/fix zenodo.
l-espana d38e98f Remove subject_id input per code review
l-espana 725cd82 Make base recon inputs more explicit per code review
l-espana 7d5253e Make longitudinal recon more explicit per code review
l-espana bdc39fc Fix typo
l-espana 78a5feb Refactor longitudinal pipeline to live within ReconAll interface.
l-espana c82b279 Black formatting.
l-espana c52cf92 Fix list_outputs typo.
l-espana 262bfb4 Additional xor/requires constraints
l-espana 46e07bb Apply formatting suggestions from code review
l-espana 123ac53 Merge branch 'master' into iss3345
effigies 34a4ac6 STY: Run black and fix typo
effigies 78d580b TEST: make specs
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to introduce additional constraints to avoid using cross-sectional specific arguments with base and long modes.
I am thinking of the
T1_files,T2_fileandFLAIR_fileparameters at least. These should probably get a requirement onsubject_id, which would achieve what we want thanks to yourxorconstraints.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That didn't cross my mind but excellent thought. I've add some requires and will test some variations next week to make sure that works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍