Skip to content

Conversation

@mgxd
Copy link
Member

@mgxd mgxd commented Jun 13, 2022

In cases where check_latest_version returned None, each time
BaseInterface.__init__ was called would lead to another server ping.
This avoids this loop by falling to a string, n/a, if the server fails
to produce a version.

Summary

Fixes #3483 .

List of changes proposed in this PR (pull-request)

In cases where `check_latest_version` returned None, each time `BaseInterface.__init__` was called would lead to another server ping. This avoids this loop by falling to a string, n/a, if the server fails to produce a version.
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3484 (5b9f3a7) into master (71c7a7d) will decrease coverage by 1.62%.
The diff coverage is 50.00%.

@@ Coverage Diff @@ ## master #3484 +/- ## ========================================== - Coverage 65.25% 63.63% -1.63%  ========================================== Files 309 309 Lines 40848 40848 Branches 5378 5378 ========================================== - Hits 26657 25993 -664  - Misses 13117 13830 +713  + Partials 1074 1025 -49 
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/__init__.py 53.19% <0.00%> (ø)
nipype/interfaces/base/core.py 85.63% <100.00%> (-2.34%) ⬇️
nipype/workflows/__init__.py 47.05% <0.00%> (-52.95%) ⬇️
nipype/utils/spm_docs.py 20.00% <0.00%> (-48.00%) ⬇️
nipype/testing/fixtures.py 57.14% <0.00%> (-41.56%) ⬇️
nipype/interfaces/freesurfer/base.py 48.38% <0.00%> (-28.23%) ⬇️
nipype/utils/logger.py 56.92% <0.00%> (-27.70%) ⬇️
nipype/interfaces/fsl/maths.py 79.06% <0.00%> (-19.19%) ⬇️
nipype/interfaces/dcm2nii.py 50.00% <0.00%> (-15.28%) ⬇️
nipype/interfaces/fsl/base.py 67.02% <0.00%> (-13.83%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c7a7d...5b9f3a7. Read the comment docs.

@effigies effigies merged commit f4343d6 into nipy:master Jun 14, 2022
@effigies effigies mentioned this pull request Jul 14, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants