[ENH] Added some options to mrconvert's interface #3474
Conversation
Codecov ReportBase: 65.29% // Head: 65.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## master #3474 +/- ## ========================================== - Coverage 65.29% 65.28% -0.01% ========================================== Files 309 309 Lines 40873 40884 +11 Branches 5380 5382 +2 ========================================== + Hits 26687 26693 +6 - Misses 13108 13113 +5 Partials 1078 1078
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| desc="""specify output image data type. | ||
| Valid choices are: float32, float32le, float32be, float64, | ||
| float64le, float64be, int64, uint64, int64le, uint64le, | ||
| int64be, uint64be, int32, uint32, int32le, uint32le, | ||
| int32be, uint32be, int16, uint16, int16le, uint16le, | ||
| int16be, uint16be, cfloat32, cfloat32le, cfloat32be, | ||
| cfloat64, cfloat64le, cfloat64be, int8, uint8, bit.""", |
There was a problem hiding this comment.
Enumerations should be added to the docstrings. Did you try building the docs locally and not see it?
| desc="""specify output image data type. | |
| Valid choices are: float32, float32le, float32be, float64, | |
| float64le, float64be, int64, uint64, int64le, uint64le, | |
| int64be, uint64be, int32, uint32, int32le, uint32le, | |
| int32be, uint32be, int16, uint16, int16le, uint16le, | |
| int16be, uint16be, cfloat32, cfloat32le, cfloat32be, | |
| cfloat64, cfloat64le, cfloat64be, int8, uint8, bit.""", | |
| desc="output image data type", |
| File("grad.bvecs", desc="bvecs"), | ||
| File("grad.bvals", desc="bvals"), |
There was a problem hiding this comment.
I'm pretty sure this metadata will have no effect. If you want to specify these things, I would add it to the desc for the entire trait.
| File("grad.bvecs", desc="bvecs"), | |
| File("grad.bvals", desc="bvals"), | |
| File, File |
| ends_only = traits.Bool( | ||
| argstr="-ends_only", desc="only map the streamline" " endpoints to the image" | ||
| argstr="-ends_only", | ||
| desc="only map the streamline" " endpoints to the image", |
There was a problem hiding this comment.
While we're modifying this line...
| desc="only map the streamline" " endpoints to the image", | |
| desc="only map the streamline endpoints to the image", |
2 participants
Summary
The MRConvert interface now includes some additional available options allowed by the original MRTrix3's CLI.
Fixes #3473.
List of changes proposed in this PR (pull-request)
The interface now includes the following: