Skip to content

Conversation

@skoudoro
Copy link
Member

This PR should fix the import issue with the DIPY interface. DIPY project introduces a new deprecator decorator which was not well handled by inspect.getfullargspec(). So, I just replace inspect.getfullargspec() by inspect.signature().

fix #3411
fix dipy/dipy#2402

Could you test this PR @koenhelwegen @HippocampusGirl? Thank you.

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.
@skoudoro skoudoro requested a review from effigies November 23, 2021 12:04
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #3414 (1e5d87e) into master (f756b71) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1e5d87e differs from pull request most recent head 37d0fa9. Consider uploading reports for the commit 37d0fa9 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@ ## master #3414 +/- ## ======================================= Coverage 65.21% 65.21% ======================================= Files 307 307 Lines 40474 40477 +3 Branches 5351 5352 +1 ======================================= + Hits 26395 26398 +3  Misses 13004 13004 Partials 1075 1075 
Flag Coverage Δ
unittests 64.95% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/info.py 92.18% <ø> (ø)
nipype/interfaces/dipy/base.py 75.86% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f756b71...37d0fa9. Read the comment docs.

skoudoro and others added 3 commits December 1, 2021 21:17
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@skoudoro
Copy link
Member Author

skoudoro commented Dec 1, 2021

Thank you for the feedback @effigies and good catch for distutils (I need to update other repo)

@effigies effigies merged commit 72c11d6 into nipy:master Dec 1, 2021
@skoudoro skoudoro deleted the fix-3411 branch December 1, 2021 20:39
HippocampusGirl added a commit to HALFpipe/HALFpipe that referenced this pull request Feb 1, 2022
@effigies effigies added this to the 1.7.1 milestone Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants