TEST: Allow SVD columns to flip sign #3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
effigies force-pushed the test/svd_sign_flip branch from f38d366 to de0d541 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #3405 +/- ## ======================================= Coverage 65.21% 65.21% ======================================= Files 307 307 Lines 40474 40474 Branches 5351 5351 ======================================= Hits 26395 26395 Misses 13004 13004 Partials 1075 1075
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Debian's updating LAPACK to 3.10 revealed that we weren't handling sign flips for CompCor components.
This patch is split into two components, one cleaning up the test so we can use
np.allclose, and the other switching to and validating an allclose that tolerates sign flips of entire columns, but not arbitrary sign flips.Closes #3382.