ENH: Modify Directory and File traits to get along with pathlib #2962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 task
| Okay, getting green lights with my user's Travis builds. |
| Cool. Will look tonight if I get a chance, otherwise first thing in the morning. Thanks for taking this one over. |
| Incidentally, we should try to have a release this month... |
This doesn't address #2944, but sets the ground to tackle it. |
satra reviewed Jul 17, 2019
effigies reviewed Jul 17, 2019
Co-Authored-By: Satrajit Ghosh <satrajit.ghosh@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Codecov Report
@@ Coverage Diff @@ ## master #2962 +/- ## ========================================== - Coverage 66.92% 64.23% -2.69% ========================================== Files 344 342 -2 Lines 43747 43744 -3 Branches 5456 5468 +12 ========================================== - Hits 29277 28100 -1177 - Misses 13722 14557 +835 - Partials 748 1087 +339
Continue to review full report at Codecov.
|
mgxd reviewed Jul 17, 2019
| local_directory = str(self.inputs.local_directory) | ||
| bucket_path = str(self.inputs.bucket_path) | ||
| template = str(self.inputs.template) | ||
| if not os.path.split(local_directory)[1] == '': |
There was a problem hiding this comment.
minor refactor for added clarity
Suggested change
| if not os.path.split(local_directory)[1] == '': | |
| if not os.path.basename(local_directory) == '': |
| template = str(self.inputs.template) | ||
| if not os.path.split(local_directory)[1] == '': | ||
| local_directory += '/' | ||
| if not os.path.split(bucket_path)[1] == '': |
There was a problem hiding this comment.
Suggested change
| if not os.path.split(bucket_path)[1] == '': | |
| if not os.path.basename(bucket_path) == '': |
effigies approved these changes Jul 17, 2019
satra approved these changes Jul 17, 2019
| Everything seems to be checking out - I'll merge, cross your fingers this doesn't break everything. |
| 🤞 |
oesteban added a commit to oesteban/nipype that referenced this pull request Jul 17, 2019
oesteban added a commit to oesteban/nipype that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #2959
Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment