Skip to content

Conversation

@effigies
Copy link
Member

Summary

Apparently we're now hitting the #2855 issue via conda in the Docker images. See #2737 (comment).

List of changes proposed in this PR (pull-request)

Installs numpy!=1.16.0 via conda.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.
@effigies effigies added this to the 1.1.8 milestone Jan 22, 2019
@codecov-io
Copy link

Codecov Report

Merging #2862 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2862 +/- ## ========================================= + Coverage 67.38% 67.4% +0.02%  ========================================= Files 341 341 Lines 43474 43474 Branches 5401 5401 ========================================= + Hits 29294 29305 +11  + Misses 13482 13472 -10  + Partials 698 697 -1
Flag Coverage Δ
#smoketests 50.48% <ø> (ø) ⬆️
#unittests 64.82% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
nipype/utils/provenance.py 84.71% <0%> (+0.63%) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 66% <0%> (+4.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b74fd2...79cc144. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #2862 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2862 +/- ## ========================================= + Coverage 67.38% 67.4% +0.02%  ========================================= Files 341 341 Lines 43474 43474 Branches 5401 5401 ========================================= + Hits 29294 29305 +11  + Misses 13482 13472 -10  + Partials 698 697 -1
Flag Coverage Δ
#smoketests 50.48% <ø> (ø) ⬆️
#unittests 64.82% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
nipype/utils/provenance.py 84.71% <0%> (+0.63%) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 66% <0%> (+4.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b74fd2...79cc144. Read the comment docs.

@effigies effigies merged commit 74eb5e5 into master Jan 23, 2019
yarikoptic added a commit to yarikoptic/nipype that referenced this pull request Feb 4, 2019
1.1.8 (January 28, 2019) * FIX: ANTS LaplacianThickness cmdline opts fixed up (nipy#2846) * FIX: Resolve LinAlgError during SVD (nipy#2838) * ENH: Add interfaces wrapping DIPY worflows (nipy#2830) * ENH: Update BIDSDataGrabber for pybids 0.7 (nipy#2737) * ENH: Add FSL `eddy_quad` interface (nipy#2825) * ENH: Support tckgen -select in MRtrix3 v3+ (nipy#2823) * ENH: Support for BIDS event files (nipy#2845) * ENH: CompositeTransformUtil, new ANTs interface (nipy#2785) * RF: Move pytest and pytest-xdist from general requirement into tests_required (nipy#2850) * DOC: Add S3DataGrabber example (nipy#2849) * DOC: Skip conftest module in API generation (nipy#2852) * DOC: Hyperlink DOIs to preferred resolver (nipy#2833) * MAINT: Install numpy!=1.16.0 from conda in Docker (nipy#2862) * MAINT: Drop pytest-xdist requirement, minimum pytest version (nipy#2856) * MAINT: Disable numpy 1.16.0 for Py2.7 (nipy#2855) * tag '1.1.8': (79 commits) MNT: Add @feilong to .zenodo, update ordering MNT: Update .mailmap MNT: Update .zenodo ordering Accept invitation as Zenodo release co-author (see nipy#2864) MAINT: Update .mailmap BF: allowing bids_event_file as alternate input MNT: Update .zenodo ordering MNT: Version 1.1.8 DOC: 1.1.8 changelog Update nipype/interfaces/dipy/tracks.py Update nipype/interfaces/dipy/reconstruction.py MNT: Install numpy!=1.16.0 from conda in Docker Add FSL auto test remake specs Update nipype/interfaces/io.py Remove return type named tuple Update nipype/info.py STY: Whitespace, line length Remove out_ prefix from EddyQuad outputs Apply minor edits from code review ...
@effigies effigies deleted the mnt/numpy_docker branch October 8, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants