Skip to content

Conversation

@effigies
Copy link
Member

@effigies effigies commented Jul 27, 2018

@effigies effigies added this to the 1.1.1 milestone Jul 27, 2018
@effigies effigies mentioned this pull request Jul 27, 2018
1 task
@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #2658 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2658 +/- ## ========================================== - Coverage 67.61% 67.61% -0.01%  ========================================== Files 340 340 Lines 43054 43054 Branches 5329 5329 ========================================== - Hits 29113 29110 -3  + Misses 13240 13235 -5  - Partials 701 709 +8
Flag Coverage Δ
#smoketests 50.47% <100%> (-0.05%) ⬇️
#unittests 65.07% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/io.py 54.41% <ø> (ø) ⬆️
nipype/interfaces/ants/registration.py 74.22% <ø> (ø) ⬆️
nipype/utils/filemanip.py 79.51% <ø> (ø) ⬆️
nipype/info.py 89.55% <100%> (-4.48%) ⬇️
nipype/interfaces/dynamic_slicer.py 17.47% <0%> (ø) ⬆️
nipype/interfaces/nipy/preprocess.py 45.79% <0%> (ø) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.11% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715ad0a...73a2e1b. Read the comment docs.

@effigies
Copy link
Member Author

@mgxd Should be ready for things like zenodo and mailmap updates.

@effigies
Copy link
Member Author

@djarecka If you get a chance, could you run the tutorials on the rel/1.1.1 branch?

@mgxd Is this otherwise good to go?

@djarecka
Copy link
Collaborator

@effigies - running the tests, will let you know

@djarecka
Copy link
Collaborator

djarecka commented Jul 30, 2018

@effigies - looks like niype_tutorial is fine

Also, I've just noticed that xdist have already a new release 1.22.5 :) I don't remember which exactly travis job was giving you error on Friday, but it looks like travis_retry is not needed anymore.
djarecka#5
Should we remove it?

@effigies
Copy link
Member Author

Sounds good. Since it's not anything that will end up in the distribution, we can fix that after release. Merging.

@effigies effigies merged commit b8a8c3a into master Jul 30, 2018
@effigies effigies deleted the rel/1.1.1 branch July 30, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants