Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Jun 22, 2017

Pull-request guidelines (Remove this section after reading):

  1. If you would like to list yourself as a Nipype contributor and your name is not mentioned please modify .zenodo.json file.
  2. By submitting this request you acknowledge that your contributions are available under the Apache 2 license.
  3. Use a descriptive prefix for your PR: ENH (enhancement), FIX, TST, DOC, STY, REF (refactor), WIP (Work in progress)
  4. The person who accepts/merges your PR will include an update to the CHANGES file: prefix: description (URL of pull request)
  5. Run make check-before-commit before submitting the PR.

----- REMOVE TILL HERE -----

Fixes # .

Changes proposed in this pull request

tsalo and others added 20 commits April 27, 2017 11:25
Added outline of classes for AFNI's 3dDeconvolve (inputspec, outputspec, and command), with test classes. Nothing is there yet, but it's something to build off of.
Didn't realize that was automatically generated, despite the incredibly obvious naming convention.
Update main command for Deconvolve.
Took a first whack at the 3dDeconvolve input spec. Just implemented 'base case' arguments--will get to other optional things later.
Updated __init__.py with Deconvolve and working to fix doctest issues.
Works! For now. Still not testing any GLTs, and formatting of some inputs is buggy.
Forces num_stimts and num_glt if stim_times and gltsym are provided
@tsalo tsalo closed this Jun 22, 2017
@codecov-io
Copy link

codecov-io commented Jun 23, 2017

Codecov Report

Merging #2086 into master will increase coverage by 0.01%.
The diff coverage is 83.92%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2086 +/- ## ========================================== + Coverage 72.13% 72.15% +0.01%  ========================================== Files 1138 1139 +1 Lines 57271 57327 +56 Branches 8207 8212 +5 ========================================== + Hits 41313 41362 +49  - Misses 14665 14671 +6  - Partials 1293 1294 +1
Flag Coverage Δ
#smoketests 72.15% <83.92%> (+0.01%) ⬆️
#unittests 69.76% <83.92%> (+0.01%) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/afni/__init__.py 100% <100%> (ø) ⬆️
nipype/interfaces/afni/model.py 83.63% <83.63%> (ø)
nipype/interfaces/base.py 83.8% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac1058...cc41ef2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants