ENH: Enable per-stage masking in ants.Registration #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
effigies force-pushed the ants/registration_masks branch from 361d297 to d27922c Compare 
Codecov Report
@@ Coverage Diff @@ ## master #2070 +/- ## ========================================== - Coverage 72.16% 72.15% -0.01% ========================================== Files 1138 1138 Lines 57229 57235 +6 Branches 8199 8200 +1 ========================================== Hits 41299 41299 - Misses 14640 14646 +6 Partials 1290 1290
Continue to review full report at Codecov.
|
effigies force-pushed the ants/registration_masks branch from d27922c to eec128e Compare 
effigies force-pushed the ants/registration_masks branch from eec128e to e97caa4 Compare 
chrisgorgo reviewed Jun 15, 2017
| desc='mask used to limit metric sampling region of the fixed image') | ||
| fixed_image_mask = InputMultiPath( | ||
| traits.Either('NULL', File(exists=True)), | ||
| desc='mask used to limit metric sampling region of the fixed image') |
Member
There was a problem hiding this comment.
Please describe the use of special string 'NULL' in the desc.
chrisgorgo approved these changes Jun 15, 2017
Member
chrisgorgo left a comment
chrisgorgo left a comment There was a problem hiding this comment.
Merge at will after the desc improvements.
Member Author
| Thanks. I'll wait for the first round of tests to finish, but won't waste time with a full Circle build on the latest. |
effigies added a commit to effigies/niworkflows that referenced this pull request Jun 15, 2017
effigies added a commit to nipreps/niworkflows that referenced this pull request Jun 15, 2017
This was referenced Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
antsRegistration permits per-stage masking, and accepts invalid filenames to indicate that no mask should be applied, providing
NULLas the example string of choice.Changes proposed in this pull request
fixed_image_maskandmoving_image_maskto be a (single or list of)'NULL'string(s) or existing file(s)This should change the command lines, but not semantics, of existing interface calls.