FIX: Import mmap into inner function for all_fsl_pipeline #2058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #2058 +/- ## ========================================== - Coverage 72.17% 72.17% -0.01% ========================================== Files 1136 1136 Lines 57146 57147 +1 Branches 8185 8185 ========================================== Hits 41243 41243 - Misses 14616 14617 +1 Partials 1287 1287
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #2058 +/- ## ========================================== - Coverage 72.17% 72.17% -0.01% ========================================== Files 1136 1136 Lines 57146 57147 +1 Branches 8185 8185 ========================================== Hits 41243 41243 - Misses 14616 14617 +1 Partials 1287 1287
Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rationale:
Similar to pull request #1831 (and follow up to #1796) there was a function level import for NUMPY_MMAP that was missing, causing a
NameErrorChanges proposed in this pull request
NUMPY_MMAPinto_gen_index[inner function ofall_fsl_pipeline]