Skip to content

Conversation

@gjcooper
Copy link
Contributor

Changes proposed in this pull request

  • PBSPro version listed below does not return Unknown Job Id when a job has finished to stderr, instead it returns a message to stderr saying that the job has finished, recommending a command to access completed job details.
  • This means that the _is_pending command continually reruns every 2 seconds (waiting for the job to complete)
  • the fix for this is to check explicitly for the job finished message, and pass along that the job is no longer pending.
$ qstat --version pbs_version = PBSPro_13.1.0.160576

All tests passed successfully with make check_before_commit

@satra satra merged commit a45001b into nipy:master Jun 3, 2017
@codecov-io
Copy link

Codecov Report

Merging #2051 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2051 +/- ## ========================================== - Coverage 72.17% 72.16% -0.01%  ========================================== Files 1134 1134 Lines 57098 57102 +4 Branches 8179 8180 +1 ========================================== Hits 41210 41210 - Misses 14602 14606 +4  Partials 1286 1286
Flag Coverage Δ
#smoketests 72.16% <0%> (-0.01%) ⬇️
#unittests 69.77% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/pipeline/plugins/pbs.py 17.14% <0%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13f967...847879a. Read the comment docs.

@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants