Skip to content

Replace deprecated HasTraits.set with trait_set #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 24, 2017
Merged

Replace deprecated HasTraits.set with trait_set #2048

merged 6 commits into from
May 24, 2017

Conversation

@effigies
Copy link
Member

@effigies effigies commented May 23, 2017

Tests are currently failing, I think at least partially because of a bunch of deprecation warnings about HasTraits.set.

This fixes that (I think). Then hopefully the logs will be clear enough to identify other issues.
@effigies
Copy link
Member Author

effigies commented May 24, 2017

Cleaned up some simple nibabel-related warnings.
@codecov-io
Copy link

codecov-io commented May 24, 2017 •
edited
Loading

Codecov Report

Merging #2048 into master will increase coverage by <.01%.
The diff coverage is 43.75%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2048 +/- ## ========================================== + Coverage 72.17% 72.17% +<.01%  ========================================== Files 1134 1134 Lines 57098 57096 -2 Branches 8179 8179 ========================================== Hits 41208 41208 + Misses 14604 14602 -2  Partials 1286 1286
Flag Coverage Δ
#smoketests 72.17% <43.75%> (ø) ⬆️
#unittests 69.78% <43.75%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/workflows/dmri/fsl/epi.py 45.11% <0%> (ø) ⬆️
nipype/interfaces/dipy/tracks.py 29.51% <0%> (ø) ⬆️
nipype/interfaces/dipy/reconstruction.py 29.64% <0%> (ø) ⬆️
nipype/interfaces/dipy/tensors.py 39.72% <0%> (ø) ⬆️
nipype/interfaces/afni/utils.py 77.35% <0%> (+0.45%) ⬆️
nipype/algorithms/confounds.py 77.93% <100%> (ø) ⬆️
nipype/interfaces/utility/base.py 91.01% <100%> (ø) ⬆️
nipype/caching/memory.py 58.06% <100%> (ø) ⬆️
nipype/algorithms/tests/test_tsnr.py 100% <100%> (ø) ⬆️
nipype/interfaces/base.py 83.77% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb37ce...1fbdaf2. Read the comment docs.
@codecov-io
Copy link

codecov-io commented May 24, 2017 •
edited
Loading

Codecov Report

Merging #2048 into master will increase coverage by <.01%.
The diff coverage is 43.75%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #2048 +/- ## ========================================== + Coverage 72.17% 72.17% +<.01%  ========================================== Files 1134 1134 Lines 57098 57096 -2 Branches 8179 8179 ========================================== Hits 41208 41208 + Misses 14604 14602 -2  Partials 1286 1286
Flag Coverage Δ
#smoketests 72.17% <43.75%> (ø) ⬆️
#unittests 69.78% <43.75%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/dipy/reconstruction.py 29.64% <0%> (ø) ⬆️
nipype/workflows/dmri/fsl/epi.py 45.11% <0%> (ø) ⬆️
nipype/interfaces/afni/utils.py 77.35% <0%> (+0.45%) ⬆️
nipype/interfaces/dipy/tensors.py 39.72% <0%> (ø) ⬆️
nipype/interfaces/dipy/tracks.py 29.51% <0%> (ø) ⬆️
nipype/algorithms/confounds.py 77.93% <100%> (ø) ⬆️
nipype/interfaces/base.py 83.77% <100%> (ø) ⬆️
nipype/algorithms/tests/test_tsnr.py 100% <100%> (ø) ⬆️
nipype/interfaces/utility/base.py 91.01% <100%> (ø) ⬆️
nipype/caching/memory.py 58.06% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb37ce...1fbdaf2. Read the comment docs.
@satra satra merged commit c4543dc into nipy:master May 24, 2017
@effigies effigies deleted the fix/deprecate_set branch May 24, 2017 10:21
oesteban
oesteban reviewed May 24, 2017
View reviewed changes
circle.yml
@@ -1,4 +1,6 @@
machine:
pre:
- curl -sSL https://s3.amazonaws.com/circle-downloads/install-circleci-docker.sh | bash -s -- 1.10.0
Copy link
Contributor

@oesteban oesteban May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break the cache (if it worked with 1.9, we didn't get it to work, right @satra?). Caching does not work with 1.10.
Copy link
Member

@satra satra May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sth weird happened with docker. i thought i had removed 1.9 and caching worked, but not after it got merged. we still have to revisit the cache situation. from a time perspective restoring and saving the cache takes almost as time as building it.
Copy link
Contributor

@oesteban oesteban May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we should probably roll back to the docker pull solution, and manually update nipype/base
Copy link
Contributor

@oesteban oesteban May 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't have hopes for getting the cache to work. Definitely not with 1.10 but 1.9 neither)
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@effigies @codecov-io @satra @oesteban