Skip to content

Conversation

satra
Copy link
Member

@satra satra commented May 12, 2017

here it is. please review this before we merge and tag the release.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here look good. Two comments/questions.

:Date: |today|

Previous versions: `0.12.0 <http://nipype.readthedocs.io/en/0.12.0/>`_ `0.11.0 <http://nipy.org/nipype/0.11.0>`_
Previous versions: `0.12.1 <http://nipype.readthedocs.io/en/0.12.1/>`_ `0.11.0 <http://nipy.org/nipype/0.11.0>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentionally dropping 0.12.0 from the list (rather than prepending 0.12.1)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - this should have been done after the 0.12.1 release but we missed it. and we use version in terms of minor element (11, 12, 13, etc.,.)

right after this release, when we switch back to the dev version this will become 0.13.0

CHANGES Outdated
Upcoming Release
=====================
0.13.0 (May 11, 2017)
============================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the extra =s are stylistically frowned upon.

@chrisgorgo
Copy link
Member

Could we hold on for a moment - @jokedurnez is about to add her name to .zenodo.json.

@satra
Copy link
Member Author

satra commented May 12, 2017

@chrisfilo - sure just ping me when it's done.

@chrisgorgo
Copy link
Member

done

* upstream/master: lets keep Satra the senior Update .zenodo.json
@satra satra merged commit 3440181 into nipy:master May 12, 2017
@satra
Copy link
Member Author

satra commented May 12, 2017

now i'll wait for everything to pass on master and look at the docs and then tag the release. i also realized that for some reason tagging on github doesn't create an annotated tag. so i'll tag locally and push the tag.

@chrisgorgo
Copy link
Member

chrisgorgo commented May 12, 2017 via email


You can follow the `Nipype tutorial <https://miykael.github.io/nipype_tutorial/>`_

or use this docker container: `docker pull nipype/nipype`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a tag to the container?

@satra satra deleted the rel/0.13.0 branch October 30, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants