doc: warn contrastmgr deprecation in fsl 5.0.7+ #1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
satra requested changes Apr 5, 2017
nipype/interfaces/fsl/model.py Outdated
| corrections file is no longer generated by FILMGLS. | ||
| """ | ||
| | ||
| if LooseVersion(FSVersion) >= LooseVersion("5.0.7"): |
There was a problem hiding this comment.
then FSLVersion would be "0"
nipype/interfaces/fsl/model.py Outdated
| BaseInterfaceInputSpec) | ||
| from .base import FSLCommand, FSLCommandInputSpec, Info | ||
| | ||
| FSVersion = "0" |
There was a problem hiding this comment.
replace this section with the version property in FSL base class.
Codecov Report
@@ Coverage Diff @@ ## master #1940 +/- ## ========================================== + Coverage 72.47% 72.47% +<.01% ========================================== Files 1063 1063 Lines 54153 54149 -4 Branches 7811 7811 ========================================== - Hits 39249 39247 -2 + Misses 13684 13682 -2 Partials 1220 1220
Continue to review full report at Codecov.
|
satra reviewed Apr 9, 2017
nipype/interfaces/fsl/model.py Outdated
| """ | ||
| | ||
| if Info.version() and LooseVersion(Info.version()) >= LooseVersion("5.0.7"): | ||
| warn("ContrastMgr is deprecated in FSL 5.0.7+", DeprecationWarning) |
There was a problem hiding this comment.
you can use DeprecationWarning without import warn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#1140