changes slice_order type from Int to Float #1724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
With the newer SPM12, it is now possible to use "slice onsets" in milliseconds, instead of the good old simple slice order. I've tested if there is any difference between slice_order [0 1 2 3,...] or [0.0 1.0 2.0 3.0,...] and with my test data there was none. SPM12 and SPM8, both accept the float point approach, but SPM8 crashes if one tries to use actual onsets, i.e. [0.0 66.66 133.33, 200.0...].
chrisgorgo reviewed Nov 29, 2016
nipype/interfaces/spm/preprocess.py Outdated
| slice_order = traits.List(traits.Int(), field='so', | ||
| desc=('1-based order in which slices are ' | ||
| slice_order = traits.List(traits.Float(), field='so', | ||
| desc=('1-based order or onset in which slices are ' |
There was a problem hiding this comment.
could you confirm SPM requires onsets in milliseconds and make it explicit in this description?
The exact description of SPM is as follows: "Alternatively you can enter the slice timing in ms for each slice individually. If doing so, the next item (Reference Slice) will contain a reference time (in ms) instead of the slice index of the reference slice."
Current coverage is 70.93% (diff: 100%)@@ master #1724 diff @@ ========================================== Files 1030 1030 Lines 51848 52191 +343 Methods 0 0 Messages 0 0 Branches 7338 7409 +71 ========================================== + Hits 36714 37021 +307 - Misses 14040 14066 +26 - Partials 1094 1104 +10
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With the newer SPM12, it is now possible to use "slice onsets" in milliseconds, instead of the good old simple slice order.
I've tested if there is any difference between slice_order [0 1 2 3,...] or [0.0 1.0 2.0 3.0,...] and with my test data there was none.
SPM12 and SPM8, both accept the float point approach, but SPM8 crashes if one tries to use actual onsets, i.e. [0.0 66.66 133.33, 200.0...].