Update example to prevent obscuring passed params #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Example in source code comments can introduce bug in user code if followed blindly, passing `params` as positional argument actually gets it assigned to parameter named `compute_all_outputs`, meaning `params` gets default values. Fix is to explicitly use named argument in function call.
chrisgorgo added a commit that referenced this pull request Feb 16, 2016
Update example to prevent obscuring passed params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Example in source code comments can introduce bug in user code if
followed blindly, passing
paramsas positional argument actually getsit assigned to parameter named
compute_all_outputs, meaningparamsgetsdefault values. Fix is to explicitly use named argument in function
call.