[FIX] Improve redirections of X #1156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| yes, i think each host should open a single display. we could check if there is a host display running under the users uid. would probably need some local locking mechanism to ensure two jobs don't start creating displays concurrently. |
| Should we merge this as a temporary patch? Is there a place to list the different feature requests apart from the issue tracker? |
nipype/interfaces/base.py Outdated
There was a problem hiding this comment.
since we are moving this, i think this could be a standalone function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes #1155. Additionally,
CommandLineInterfacehas been also modified to be run with thexvfb-runscript.Question: maybe the approach should be opening just one virtual display and redirecting all the nodes with redirect_x in the host to that display. What do you think? Currently, a lot of new virtual displays need to be open, but only one per host is enough.