Skip to content

fixed typo op.abspath to os.abspath #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2015
Merged

fixed typo op.abspath to os.abspath #1083

merged 3 commits into from
Apr 12, 2015

Conversation

@fliem
Copy link
Contributor

@fliem fliem commented Apr 11, 2015

No description provided.

@coveralls
Copy link

coveralls commented Apr 11, 2015

Coverage Status

Coverage decreased (-0.02%) to 70.46% when pulling 19eab7c on fliem:master into 5ca0086 on nipy:master.
@mwaskom
Copy link
Member

mwaskom commented Apr 11, 2015

You need to make this os.path.abspath, there isn't an os.abspath function.

I'm actually a little surprised the tests passed?
@satra
Copy link
Member

satra commented Apr 11, 2015

this is inside list_outputs and is dependent on an input. the tests don't catch that (yet!).

@fliem - once you make the change @mwaskom suggested we can merge this.
@fliem
Copy link
Contributor Author

fliem commented Apr 12, 2015

Thanks @mwaskom. I changed it.
Best,
Franz
satra added a commit that referenced this pull request Apr 12, 2015
@satra
Merge pull request #1083 from fliem/master
c1a5ea0 
fixed typo op.abspath to os.abspath
@satra satra merged commit c1a5ea0 into nipy:master Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@fliem @coveralls @mwaskom @satra