return raw post rst when rendering fails #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| CI fail is from a network error, unrelated to the changes |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR introduces a simple change to show the raw RST text when a post fails to render (as discussed in #330). This should improve the experience when reading older threads where the issue is more prevalent, and improve visibility with search engines that can now pick up the original post content instead of the error message. It's been suggested that recent improvements to the RST parser will reduce the amount of these problematic posts as well.
I have used the content of the first post from this thread for testing.
Before:
After:
I've also tested that embedding the raw post does not allow for js injection.