fixes #25296; get CPU arch from gcc #25297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bptato reviewed Nov 19, 2025
tools/niminst/makefile.nimf Outdated
| ## it should also get OS from GCC so that csource can be build with more GCC for cross compilation. | ||
| ## but parsing OS name from `gcc -dumpmachine` is hard: | ||
| ## https://wiki.osdev.org/Target_Triplet | ||
| ucpu := $(shell sh -c 'gcc -dumpmachine | cut --delimiter=- --field=1 | tr "[:upper:]" "[:lower:]"') |
Contributor
There was a problem hiding this comment.
Long options are a GNUism so this won't work on FreeBSD etc. cut -d - -f 1 seems preferable.
Also, later down the file there's this line:
mycpu = $(shell /bin/sh -c '"$(CC)" -dumpmachine | sed "s/-.*//"')clang supports dumpmachine too, so maybe $(CC) is better?
Contributor Author
There was a problem hiding this comment.
Thank you! I wasn't aware there is already code calls $(CC) -dumpmachine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.