Implement setLineInfo #21153
Merged
Implement setLineInfo #21153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Could it be implemented as a VM callback? |
Member
| Not the right feature for the callback mechanism. @narimiran please backport to 2.0 |
Contributor
| Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran pushed a commit that referenced this pull request Dec 22, 2022
* Implement setLineInfo * Add tests (cherry picked from commit 613829f)
Contributor
| can we backport this to 1.6 as well? |
Contributor
| ping @narimiran |
narimiran pushed a commit that referenced this pull request Jan 19, 2023
* Implement setLineInfo * Add tests (cherry picked from commit 613829f)
Member
| Backported to 1.6. |
survivorm pushed a commit to survivorm/Nim that referenced this pull request Feb 28, 2023
* Implement setLineInfo * Add tests
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
* Implement setLineInfo * Add tests
Closed
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
* Implement setLineInfo * Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This closes #21098 by implementing a setLineInfo procedure in the
macrosmodule and new magics to support it. I saw that the getter procedures weren't exported so I didn't export the setter procedures either, although I believe we should export both. Just let me know and I can fix that in this PR.