fix semcase on tySequence and tyObject #20283 #19682 #20339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bung87 force-pushed the fix20283 branch 2 times, most recently from a4f8828 to 1896e86 Compare 
Araq reviewed Sep 28, 2022
Araq reviewed Oct 11, 2022
Collaborator Author
| @Araq merge this pls, just a tiny patch |
Contributor
| Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
…im-lang#20339) * fix semcase on tySequence and tyObject nim-lang#20283 nim-lang#19682 * use better arg name * avoiding returns nil use errorNode instead, clean code * use efNoDiagnostics flag * remove tests/errmsgs/t19682.nim * combine 2 test cases to one file
bung87 added a commit to bung87/Nim that referenced this pull request Jul 29, 2023
…im-lang#20339) * fix semcase on tySequence and tyObject nim-lang#20283 nim-lang#19682 * use better arg name * avoiding returns nil use errorNode instead, clean code * use efNoDiagnostics flag * remove tests/errmsgs/t19682.nim * combine 2 test cases to one file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #20283
fix #19682
Note: I can add a extro param to
resolveOverloadssince this is only one case need to take care of, so that avoidingif f.kind == nkIdent and f.ident.s == "case":edit: now I change to use a flag.
when I use
case [], do nim check insidesemStmtListwill cause nil access, so I add a conditionif x == nil. andthe test file produce duplicated error, no idea so far.