Skip to content

Conversation

@ghostwriter
Copy link
Contributor

@ghostwriter ghostwriter commented Dec 4, 2024

This patch resolves #1045, via the following changes:

Added namespace and a conditional class declaration in:

  • lib/PhpParser/Node/Expr/ArrayItem.php
  • lib/PhpParser/Node/Expr/ClosureUse.php
  • lib/PhpParser/Node/Scalar/DNumber.php
  • lib/PhpParser/Node/Scalar/Encapsed.php
  • lib/PhpParser/Node/Scalar/EncapsedStringPart.php
  • lib/PhpParser/Node/Scalar/LNumber.php
  • lib/PhpParser/Node/Stmt/DeclareDeclare.php
  • lib/PhpParser/Node/Stmt/PropertyProperty.php
  • lib/PhpParser/Node/Stmt/StaticVar.php
  • lib/PhpParser/Node/Stmt/UseUse.php
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@nikic nikic merged commit 469377f into nikic:master Dec 6, 2024
10 checks passed
@ghostwriter ghostwriter deleted the oss/nikic/php-parser/issues-1045 branch December 6, 2024 23:02
@sebastianbergmann
Copy link
Contributor

FYI: These changes caused PHPUnit's PHAR to stop working. Details are here: sebastianbergmann/phpunit#6092

I worked around this in sebastianbergmann/phpunit@e299d61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants