Fix OIDC client authentication for POST method after f7e8726 #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove the `proxy_pass_request_body off` directive, which unintentionally broke OIDC client authentication using the POST body method (`client_secret_post`). Previously, when `$oidc_client_auth_method` was set to "client_secret_post" the `generateTokenRequestParams()` function correctly formatted the POST request and sent it via `r.subrequest` to the internal `/_token` location. However, the `proxy_pass_request_body off` directive caused the POST request to reach `$oidc_token_endpoint` with a valid Content-Length header but an empty body. This led to a timeout as the OP token endpoint closed the connection. Users encountered the error: "NGINX / OpenID Connect login failure." This commit restores functionality by ensuring the request body is passed to the token endpoint while retaining header exclusion to prevent CORS issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove the
proxy_pass_request_body offdirective, which unintentionally broke OIDC client authentication using the POST body method (client_secret_post).Previously, when
$oidc_client_auth_methodwas set to "client_secret_post" thegenerateTokenRequestParams()function correctly formatted the POST request and sent it viar.subrequestto the internal/_tokenlocation. However, theproxy_pass_request_body offdirective caused the POST request to reach$oidc_token_endpointwith a valid Content-Length header but an empty body. This led to a timeout as the OP token endpoint closed the connection.Users encountered the error: "NGINX / OpenID Connect login failure."
This commit restores functionality by ensuring the request body is passed to the token endpoint while retaining header exclusion to prevent CORS issues.