Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Conversation

@ciroque
Copy link
Collaborator

@ciroque ciroque commented Feb 13, 2023

  • Remove old environment variable
  • Deploy to nkl namespace

Proposed changes

There was cruft in the deployment from when the implementation could handle only one NGINX+ Edge host. That configuration has been moved into a ConfigMap, this removes the configuration from the deployment.

Also, the deployment was going into the default namespace, the deployment now uses the nkl namespace.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
- Remove old environment variable - Deploy to nkl namespace
@ciroque ciroque merged commit 6fe6efb into main Feb 13, 2023
@ciroque ciroque deleted the cleanup branch February 13, 2023 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant