Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Conversation

@ciroque
Copy link
Collaborator

@ciroque ciroque commented Feb 10, 2023

Settings using Informer instead of Watch

Closes #4

Proposed changes

This change adds support for maintaining multiple NGINX+ Edge Load Balancers. Also, the environment variable configuration has been replaced with a ConfigMap so updates can be performed on the fly without restarting or redeploying the controller.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
Copy link
Contributor

@chrisakker chrisakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Settings using Informer instead of Watch
@ciroque ciroque force-pushed the support-ha-nginx+-configuration branch from 92cd76b to 978cfba Compare February 13, 2023 17:15
@ciroque ciroque merged commit bcd06b8 into main Feb 13, 2023
@ciroque ciroque deleted the support-ha-nginx+-configuration branch February 13, 2023 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants