This repository was archived by the owner on Aug 22, 2025. It is now read-only.
Iss 16 oss friendly readme #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
4141done approved these changes Apr 19, 2023
There was a problem hiding this comment.
I think this is a really great start. I like the tone, and this is the most understandable explanation of NKL I've read. Kudos! Consider all my comments optional, but I would really recommend a single really simple mermaid diagram showing the how NKL lives in the cluster and pushes information to the nginx instances.
Another thing I'd like to see explored in detail is how this solution compares to MetalLB. That could either be at the bottom or in /docs
4141done approved these changes Apr 25, 2023
ciroque force-pushed the iss-16-oss-friendly-readme branch from 8a4e0ad to 5dc3e38 Compare 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.mdandCHANGELOG.md)