Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Conversation

@ciroque
Copy link
Collaborator

@ciroque ciroque commented Mar 9, 2023

  • Move setting to the configuration
  • Adds tests for probation modules
  • Minor cleanups
  • Updates tests for the Watcher
  • Updates tests for the Handler
  • Furthering the settings refactor
  • Add Synchronizer tests
  • Warming up my refactoring muscles
  • Squash Here : More and Better tests

Proposed changes

Work to improve the repo for release as open source. Mostly focused on adding tests, plenty of refactoring is involved, make more use of interfaces, moving hard-coded values to configuration, and some inversion of control improvements.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
- Move setting to the configuration - Adds tests for probation modules - Minor cleanups - Updates tests for the Watcher - Updates tests for the Handler - Furthering the settings refactor - Add Synchronizer tests - Warming up my refactoring muscles - Squash Here : More and Better tests
@ciroque ciroque requested review from chrisakker and sdutta9 March 9, 2023 22:25
Copy link
Contributor

@chrisakker chrisakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@chrisakker chrisakker merged commit e5a674b into main Mar 9, 2023
@ciroque ciroque deleted the updated-tests branch March 9, 2023 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants