-   Notifications  
You must be signed in to change notification settings  - Fork 140
 
Update GatewayAPI to v1.4.0 #4166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e403a72 to 514c578   Compare    Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@ Coverage Diff @@ ## main #4166 +/- ## ========================================== + Coverage 86.00% 86.02% +0.01%  ========================================== Files 131 131 Lines 14111 14106 -5 Branches 35 35 ========================================== - Hits 12136 12134 -2  + Misses 1772 1767 -5  - Partials 203 205 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  |  
514c578 to 446b1bc   Compare   446b1bc to 737f57a   Compare   There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this PR is also updating inference extension from 1.0.2 -> 1.1.0, which i guess is fine, but was that intentional? If so we should add that to the PR notes.
 
 @bjee19 Good catch Ben - yes I needed to update this as well as there was a misnamed variable being referenced somewhere causing conformance tests to fail. I named the commit (Upgrade inference extension to v1.1.0 to fix conformance tests) but neglected to update the notes. Thank you!!  |  
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
14054ba to ea507a5   Compare   ea507a5 to ed6e380   Compare   |   We should update the release note with info about Inference extension version bump  |  
Proposed changes
Problem: We don't currently support the latest version of the Gateway API
Solution: Upgrade to v1.4.0, including BackendTLSPolicy promotion -> v1 and other Policy type promotion -> v1. See the full changelog. Also enables the conformance tests for BackendTLSPolicy.
This also requires upgrading the inference extension from 1.0.2 -> 1.1.0 to resolve dependency conflicts.
Testing: unit testing, running the pipeline for conformance and functional testing, but the RC run passed conformance.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #4034
Closes #3795
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.