Skip to content

(Cherry-pick) Fix NFR tests (#3722) #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

(Cherry-pick) Fix NFR tests (#3722) #3723

merged 1 commit into from
Aug 12, 2025

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Aug 12, 2025

Cherry-pick #3722
@bjee19
Fix NFR tests (#3722)
87c866e 
NFR tests were having some issues regarding applying the NginxProxy CRD and timing out when deleting the test namespace while cleaning up resources. Fixed the CRD issues by applying with additional flag and increased deletion namespace timeout.
@bjee19 bjee19 requested a review from a team as a code owner August 12, 2025 20:44
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 12, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.91%. Comparing base (00112a4) to head (87c866e).
⚠️ Report is 1 commits behind head on release-2.1.

Additional details and impacted files 
@@ Coverage Diff @@ ## release-2.1 #3723 +/- ## =============================================== - Coverage 86.95% 86.91% -0.04%  =============================================== Files 128 128 Lines 15962 15962 Branches 62 62 =============================================== - Hits 13879 13873 -6  - Misses 1917 1921 +4  - Partials 166 168 +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@bjee19 bjee19 merged commit 31cf91c into release-2.1 Aug 12, 2025
65 of 66 checks passed
@bjee19 bjee19 deleted the cherry-pick/nfr-fix branch August 12, 2025 22:46
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

3 participants

@bjee19 @sjberman @sarthyparty