Skip to content

Conversation

tataruty
Copy link
Contributor

@tataruty tataruty commented Jul 1, 2025

Proposed changes

There is forgotten comment about ToDo that needed to be removed during #3528 fix

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

NONE 
@tataruty tataruty requested a review from a team as a code owner July 1, 2025 09:00
@github-actions github-actions bot added chore Pull requests for routine tasks helm-chart Relates to helm chart labels Jul 1, 2025
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (573828e) to head (fb037d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #3572 +/- ## ======================================= Coverage 86.89% 86.89% ======================================= Files 127 127 Lines 15226 15226 Branches 62 62 ======================================= Hits 13231 13231 Misses 1844 1844 Partials 151 151 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@tataruty tataruty force-pushed the chore/remove_omitted_comment branch from 2b46f6a to a6fcf03 Compare July 1, 2025 15:23
@tataruty tataruty merged commit 58ab6e2 into main Jul 2, 2025
50 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 2, 2025
@tataruty tataruty deleted the chore/remove_omitted_comment branch July 2, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks helm-chart Relates to helm chart

4 participants