Skip to content

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Jun 2, 2025

Problem: The service annotation for the GKE services was improperly formatted.

Solution: Fix the annotation so it provisions the proper service.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

 
Problem: The service annotation for the GKE services was improperly formatted. Solution: Fix the annotation so it provisions the proper service.
@sjberman sjberman requested a review from a team as a code owner June 2, 2025 15:49
@github-actions github-actions bot added tests Pull requests that update tests helm-chart Relates to helm chart labels Jun 2, 2025
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (699fed9) to head (9f39650).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #3431 +/- ## ========================================== - Coverage 86.77% 86.74% -0.04%  ========================================== Files 127 127 Lines 15068 15068 Branches 62 62 ========================================== - Hits 13075 13070 -5  - Misses 1841 1845 +4  - Partials 152 153 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@sjberman sjberman enabled auto-merge (squash) June 2, 2025 17:47
@sjberman sjberman disabled auto-merge June 2, 2025 18:36
@sjberman sjberman merged commit 3dae17e into main Jun 2, 2025
42 of 50 checks passed
@sjberman sjberman deleted the tests/service-ip branch June 2, 2025 19:40
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jun 2, 2025
sjberman added a commit that referenced this pull request Jun 2, 2025
Problem: The service annotation for the GKE services was improperly formatted. Solution: Fix the annotation so it provisions the proper service.
sjberman added a commit that referenced this pull request Jun 2, 2025
…#3437) * Add 2.0 longevity results (#3429) Adding longevity results for 2.0. These results are not complete and may be inaccurate. The tests were stopped early and the teardown scripts/functions did not collect everything properly. * Use proper internal GKE service annotation (#3431) Problem: The service annotation for the GKE services was improperly formatted. Solution: Fix the annotation so it provisions the proper service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm-chart Relates to helm chart tests Pull requests that update tests

3 participants