Skip to content

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 15, 2024

Proposed changes

Move EventRecorder to main() function to allow Pod events to be generated on pod initialisation.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
@pdabelf5 pdabelf5 requested a review from a team as a code owner November 15, 2024 11:26
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 15, 2024
@pdabelf5 pdabelf5 merged commit 8703f0e into main Nov 15, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the recorder-refactor branch November 15, 2024 12:47
@pdabelf5 pdabelf5 changed the title allow k8s events in initial validation Allow k8s events in initial validation Dec 16, 2024
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

4 participants