Skip to content

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 3, 2025

Proposed changes

  • Added tests:
    • Add, Update & Delete File Config Apply Using Mock (New sub directory)
    • Add, Update & Delete File on Data Plane (New sub directory)
    • Add Check for Manifest file for all Config Apply Tests
    • Fix Mock Management Plane to allowing Adding of new file

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13
@aphralG aphralG self-assigned this Sep 3, 2025
@aphralG aphralG requested a review from a team as a code owner September 3, 2025 09:20
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 3, 2025
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need to add test numbers in test names e.g. TestConfigApply_Test4_TestInvalidConfig. Names should be enough TestConfigApply_InvalidConfig,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in office - Test Suites run in alphabetical order so to get the tests to run in specific order need to be numbered.

@aphralG aphralG merged commit d267a13 into main Sep 4, 2025
60 of 62 checks passed
@aphralG aphralG deleted the expand-config-apply-integration-tests branch September 4, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
4 participants