Skip to content

Conversation

@prototaxites
Copy link
Contributor

Added error handling for cases with no bins passing the size filter.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
jfy133 and others added 2 commits September 30, 2025 09:35
Release: 5.0.0 Green Squirrel
Added error handling for cases with no bins passing the size filter.
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.3.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@prototaxites prototaxites changed the base branch from main to dev October 22, 2025 11:52
@prototaxites
Copy link
Contributor Author

@nf-core-bot fix linting

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by breaking the megahit command, and error seen in dev is now removed in this branch, so LGTM tiny change to CHANGELOG and can merge :)

Thanks @prototaxites !

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@prototaxites prototaxites merged commit 6b7cb5e into nf-core:dev Oct 24, 2025
37 of 39 checks passed
@prototaxites prototaxites deleted the fix_bin_count_error branch October 24, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants