Skip to content

Conversation

@dialvarezs
Copy link
Member

@dialvarezs dialvarezs commented Dec 9, 2024

This PR solves errors/warings reported by the Nextflow language server.
Mostly reused variable names and unused variables.
Additionally, I applied module updates that include error fixes.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
@dialvarezs dialvarezs marked this pull request as draft December 9, 2024 06:08
@dialvarezs dialvarezs changed the base branch from master to dev December 9, 2024 06:09
@nf-core nf-core deleted a comment from github-actions bot Dec 9, 2024
@dialvarezs dialvarezs changed the title Solve languageserver errors Fix languageserver errors Dec 9, 2024
@prototaxites
Copy link
Contributor

Two PRs that fix language server errors in modules:

nf-core/modules#7432
nf-core/modules#7431

@dialvarezs dialvarezs marked this pull request as ready for review February 16, 2025 19:52
@dialvarezs
Copy link
Member Author

Should I also format the local modules and subworflows with the LSP formatter as part of this PR? What do you think about that @jfy133?

@prototaxites
Copy link
Contributor

Should I also format the local modules and subworflows with the LSP formatter as part of this PR? What do you think about that @jfy133?

IMO unless it's something we can enforce (e.g. through a linting check) it's probably not super important as future PRs might change this?

@dialvarezs
Copy link
Member Author

Should I also format the local modules and subworflows with the LSP formatter as part of this PR? What do you think about that @jfy133?

IMO unless it's something we can enforce (e.g. through a linting check) it's probably not super important as future PRs might change this?

Sure, you're right on that, using a linting check would be better to keep a consistent style over time.

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments but I think the purpose of this PR is satisfied :) thank you very much for this @dialvarezs !

dialvarezs and others added 3 commits March 13, 2025 10:38
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@dialvarezs dialvarezs merged commit 4fa99d3 into nf-core:dev Mar 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants