Skip to content

Conversation

@leper
Copy link
Contributor

@leper leper commented Aug 29, 2025

The password object is optional and not sent in case sharing is disabled.

The added test fails before the code changes in the same way as the app does.

The password object is optional and not sent in case sharing is disabled. Signed-off-by: leper <leper4@protonmail.com>
@tobiasKaminsky
Copy link
Member

Many thanks 🙏
Also very cool that you wrote a test!

@tobiasKaminsky tobiasKaminsky merged commit c716b11 into nextcloud:main Sep 8, 2025
14 of 15 checks passed
@leper
Copy link
Contributor Author

leper commented Sep 8, 2025

You're welcome. Is there any chance to get this included in a release sometime soon? That would allow me to switch a few endpoints back to app store versions.

@tobiasKaminsky
Copy link
Member

We have released 4.5.0 RC1 this week.
If everything is fine, we will release a final next week.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment