🎨 Migrate to outline icon style #2704
Conversation
AndyScherzinger force-pushed the style/noid/outlineIcons branch 4 times, most recently from 2513d24 to e77f192 Compare AndyScherzinger force-pushed the style/noid/outlineIcons branch from e77f192 to bb644fc Compare AndyScherzinger changed the title 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger force-pushed the style/noid/outlineIcons branch from bb644fc to 8b48dc0 Compare 
| Looks good to me, but I think share internal link icon needs to be changed?
|
@jancborchardt what do you think? #2704 (comment) it is the icon we also use in all other clients and web at the moment, not sure there is an alternative we want to switch to. It is an outlined icon already after all. |
jancborchardt left a comment
jancborchardt left a comment There was a problem hiding this comment.
Looks good to me, but I think share internal link icon needs to be changed?
@jancborchardt what do you think? #2704 (comment) it is the icon we also use in all other clients and web at the moment, not sure there is an alternative we want to switch to. It is an outlined icon already after all.
Yeah, the icon looks good, I’m a bit confused as to why it would have to be changed? It’s outlined as you say.
Yes, the icon is outlined, but the circle background for the internal share link doesn't match the rest of the screen. I think having an outlined icon with filled background looks weird. I just noticed that, but we can skip it (or for now), since all the icons have been replaced correctly and the app is running without issues. Thanks for the input. |
AndyScherzinger changed the title 
No description provided.