Fixed type issue in crop function #217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| +1 for quick release - its currently blocking my autobuild flow |
dg force-pushed the master branch 4 times, most recently from 87abd34 to ca47cf7 Compare dg added a commit that referenced this pull request Nov 5, 2020
dg added a commit that referenced this pull request Nov 5, 2020
dg added a commit that referenced this pull request Nov 5, 2020
dg added a commit that referenced this pull request Nov 5, 2020
dg added a commit that referenced this pull request Nov 5, 2020
dg added a commit that referenced this pull request Nov 5, 2020
dg added a commit that referenced this pull request Nov 5, 2020
dg added a commit that referenced this pull request Nov 5, 2020
dg added a commit that referenced this pull request Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When type of width and height is string without "%" char, line 392 and 393 throws "must be of the type integer, string given". (Happened with webchemistry/images img macro with exact resize).