Skip to content

Assert::match does not match valid regex #350

@PunchyRascal

Description

@PunchyRascal
  • bug report? yes/no
  • feature request? yes/no
  • version: v1.7.1

Description

Until you realize, that your regex pattern cannot be delimited with /, the function does not work properly.

Steps To Reproduce

fails: Assert::match('/^foo$/', 'foo');
passes: Assert::match('#^foo$#', 'foo');

Perhaps it would be better to avoid this magic behavior (there is no indication you have done anything wrong) and add an extra assert for those tester expressions (with appropriate name) and keep this only for regular expressions, to avoid confusion. Or vice versa.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions