Skip to content

Conversation

@duxthefux
Copy link

@duxthefux duxthefux commented Feb 10, 2020

@duxthefux
Copy link
Author

Please note that static getter and setter was added to force type safety

@duxthefux duxthefux force-pushed the #55 branch 5 times, most recently from d7f12cb to 2162d48 Compare February 10, 2020 13:33
@dg
Copy link
Member

dg commented Feb 13, 2020

Thanks for PR.

I have this thing on the TODO list. However, the solution is not so simple, because it is not possible to use static variables in Nette (because it follows the principles of dependency injection).

So this will be a little harder to solve. I'll leave it open so far.

@duxthefux
Copy link
Author

hey @dg,

any update on this?
As far as I can see it no dependency injection via nette container is used for the Dumper-class currently. So maybe it's not that tragic to use a static property now, as a lot of refactoring needs to be done anyways to get rid of calls like (new Dumper)->format($code, ...$args).

Happy to hear your opinion.

@dg dg force-pushed the master branch 6 times, most recently from 40d6435 to f4f1e78 Compare May 6, 2020 21:27
@dg dg force-pushed the master branch 2 times, most recently from c4955b7 to ea2c8e8 Compare May 26, 2020 16:35
@dg dg force-pushed the master branch 2 times, most recently from 53b1239 to 7051954 Compare June 19, 2020 14:32
@dg dg force-pushed the master branch 9 times, most recently from 668af8c to fc70bcb Compare October 22, 2020 16:12
@dg dg force-pushed the master branch 22 times, most recently from 698c05a to aabd8f3 Compare September 23, 2021 17:07
@dg
Copy link
Member

dg commented Sep 23, 2021

Printer has new property $wrapLength

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants